search

kdave / btrfsmaintenance

Scripts for btrfs maintenance tasks like periodic scrub, balance, trim or defrag on selected mountpoints or directories.
GNU General Public License v2.0
927 stars 79 forks source link

BTRFS_VERBOSITY missing #5

Closed billimek closed 8 years ago

billimek commented 8 years ago

In btrfs-defrag.sh there is a reference to $BTRFS_VERBOSITY in the execution of the find command.

Specifically,

find "$P" -size "$BTRFS_DEFRAG_MIN_SIZE" -type f -xdev \ -exec /sbin/btrfs filesystem defrag -t 32m -f "$BTRFS_VERBOSITY" '{}' \;

This causes an execution error as the "$BTRFS_VERBOSITY" gets translated as "" which causes an error with find (at least find v4.4.2)

kdave commented 8 years ago

The variable hasn't appeared in git AFAICS, though I see it in preliminary versions of the tool so there are users, it got lost from the sysconfig template. I'll remove the qutoes for now and look if we want the variable.