Honor the server-provided timeout advice when making long-polling requests

kdcllc / CometD.NetCore

CometD for use with Salesforce Platform Events

MIT License

28 stars 16 forks source link

Honor the server-provided timeout advice when making long-polling requests #17

Closed jesbacon closed 3 years ago

jesbacon commented 3 years ago

This is in reference to #13.

When making connect calls, set the timeout value of the HttpWebRequest according to the server's advice plus a configurable network delay.

This should help in cases where the server's preferred long polling timeout is longer than the HttpWebRequest's default timeout of 100s.

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging f8fca07c5ac77ee724dd47b34b38664c6b623e81 into 5e0270891a5c6fd5f6f71e505ada7953ab54a20f - view on LGTM.com

new alerts:

1 for Dereferenced variable may be null

ttjackott commented 3 years ago

@kdcllc is this ok to go through? We would very much benefit from this!