search

kdcllc / CometD.NetCore

CometD for use with Salesforce Platform Events
MIT License
28 stars 16 forks source link

Switch more console writelines to injected loggers #4

Closed martin-podlubny closed 5 years ago

martin-podlubny commented 5 years ago

I was missing the option to turn off the stdout spam from a few Console.WriteLine(...) statements.

I switched the implementation to be silent by default, unless injected with an instance of a logger. Non-breaking change from the API point of view. Also now that the logger is a deliberate decision, I uncommented some of the commented debug statements -- they seemed like they could be handy. Letting the consumer who provides the logger worry about the amount of info.

Again, props to kdcllc for the awesome work in the first place!

kdcllc commented 5 years ago

@martin-podlubny thank you for this PR. I was thinking about making this enabled but didn't have a chance yet to get there. I know it will be beneficial for others! Blessings!