search

kdcro101 / vscode-favorites

Add files and directories to workspace favorites. You can create groups (and subgroups) of favorite items with files and folders. Time saver for complex projects.
MIT License
49 stars 13 forks source link

Potential to store settings somewhere else #13

Closed theomjones closed 5 years ago

theomjones commented 6 years ago

I was wondering if there might be a way settings can be stored somewhere other than settings.json. In my team we have .vscode/settings.json checked in as we have certain useful things such as excluding build/compile directories from search and the file tree. But of course checking in Favourites changes is an issue in a shared workspace.

This is more of an issue to invoke discussion, rather than an immediate feature request.

kdcro101 commented 6 years ago

@theomjones ,

Thank you for your feedback.

I am planning to move storage of favorite items definitions from workspace to file .favorites.json in workspace root. To do that I have to make some fundamental changes.

I will keep you posted here

ybilianskey commented 6 years ago

Probably, moving favorites settings to dedicated location should fix another issue: each favorites version update deletes user-selected colors (svg-generated folder). That's frustrating :(

kdcro101 commented 6 years ago

@ybilianskey ,

Thank you for your feedback!

Sorry to hear you have problems with colors. I will fix that in next update!

Please open issue if you have suggestion or bug to report.

kdcro101 commented 6 years ago

@ybilianskey ,

Update to 1.9.6. Problem should be fixed.

Please, let mi know how it went!

If you have any problems open issue.

ybilianskey commented 6 years ago

It was a super-fast fix and it works fine know. Thank you very much for nice add-in and level of support that is simply fantastic!

kdcro101 commented 6 years ago

@ybilianskey ,

No problem! Glad to hear that problem is gone and that extension works out for you!

kdcro101 commented 5 years ago

@theomjones ,

Please update to 2.0.0.. Favorites are are stored in workspace root as file .favorites.json. In case of multiroot workspace, file is located in first workspace.

If you have any problems, open issue.

MarekLew commented 5 years ago

I like stored favorites in .code-worksapces file. It would be good if this option existed.