search

kdcro101 / vscode-favorites

Add files and directories to workspace favorites. You can create groups (and subgroups) of favorite items with files and folders. Time saver for complex projects.
MIT License
49 stars 13 forks source link

Ignore excluded files on TreeView #17

Closed StanleySathler closed 5 years ago

StanleySathler commented 5 years ago

Hey guys, Thanks for the awesome work!

I could notice the Favorite TreeView also lists files that are included in the files.exclude setting. Should we also consider this option while listing the files, just like the original TreeView does?

kdcro101 commented 5 years ago

@StanleySathler ,

Thank you for your feedback.

I am planning to filter out excluded patterns.

I will keep you posted here.

StanleySathler commented 5 years ago

Hey @kdcro101

Thanks for answering. I'd be very happy to contribute to the project by submiting a PR for this.

kdcro101 commented 5 years ago

@StanleySathler ,

Thank you for offering help. I really appreciate it. To implement this functionality, I had to make some deep changes.

Please update to 2.1.2. Files/Directories/Favorites matched by patterns defined in files.exclude will be excluded.

You can turn feature off by setting favorites.useFilesExclude to false (default is true).

If you have any problems, open issue.