search

kdcro101 / vscode-favorites

Add files and directories to workspace favorites. You can create groups (and subgroups) of favorite items with files and folders. Time saver for complex projects.
MIT License
49 stars 13 forks source link

Place .favourites.json inside .vscode folder #18

Closed Yanpas closed 5 years ago

Yanpas commented 5 years ago

Currently it introduces a lot of noise with svn / git

kdcro101 commented 5 years ago

@Yanpas ,

Thank you for your feedback.

I have annouced location in #13. What kind of "noise" do you mean?

kdcro101 commented 5 years ago

@theomjones, what is your take on this?

Yanpas commented 5 years ago

This file is marked as unversioned and I have blue badge "1" .

Many vscode extensions place their data to .vscode (cquery, cpp, sftp e.g.). It's easy to clean all .vscode settings simply removing this directory.

.vscode/favorites.json is more conventional IMO.

kdcro101 commented 5 years ago

@Yanpas ,

I also think that .vscode/favorites.json is better location.

Please update to 2.0.1. Location of favorites is in .vscode/favorites.json in workspace folder. In case of multiroot project, it is located in same location in first workspace.

Thank you for your feedback.

If you have any problems, open issue.

Yanpas commented 5 years ago

Thank you 🤝

MarekLew commented 5 years ago

Location of favorites is in .vscode/favorites.json in workspace folde? I hanged workspace order or add/delete it automatically. Please add link to file(favorites.json) in work WORKSPACE SETTINGS.

kdcro101 commented 5 years ago

@Yanpas ,

To hardcode .vscode was bad idea. I've added configuration item favorites.storageFilePath. Default is .favorites.json. Set favorites.storageFilePath as path relative to your workspace, in your case it would be .vscode/favorites.json.

Hope everything goes well.

If you have any problems, open issue.

theomjones commented 5 years ago

Nice work @kdcro101! I think this is a great solution!

kdcro101 commented 5 years ago

@theomjones ,

Thanks! Glad you like it

hsandt commented 5 years ago

Nice!

Note that you can also set favorites.storageFilePath in the User Settings, as it will still use a path relative to the workspace.

In my opinion, .vscode/favorites.json should be the default, but it's not a big deal as long as users can tweak this just by having a look at the plugin settings. Once you configured it in the User Settings, it should apply to all workspaces anyway.