search

kdcro101 / vscode-favorites

Add files and directories to workspace favorites. You can create groups (and subgroups) of favorite items with files and folders. Time saver for complex projects.
MIT License
49 stars 13 forks source link

Proposed API is only available when running out of dev or with the following command line switch #51

Closed shiraze closed 4 years ago

shiraze commented 4 years ago

Describe the bug I now see the following warning when launching VSCode: [kdcro101.favorites]: Proposed API is only available when running out of dev or with the following command line switch: --enable-proposed-api kdcro101.favorites

To Reproduce Launch VSCode when a list of favorites has been set up

Expected behavior I would expect to see list of favorites in left pane

Screenshots image image

System info (please complete the following information):

Additional info I'm not sure where the list of favorites files are stored. I only see this issue on VSCode projects that make use of favorites.

shiraze commented 4 years ago

Found the "favorites" file - stored as .favorites.json in root folder for project. This is contents of file:

[
    {
        "type": "File",
        "name": "c:\\IS Transfer\\Source\\React\\react\\public\\appSettings.js",
        "parent_id": null,
        "fsPath": "c:\\IS Transfer\\Source\\React\\react\\public\\appSettings.js",
        "workspaceRoot": null,
        "workspacePath": null,
        "id": "J741zfpQAMCU5grI"
    },
    {
        "type": "File",
        "name": "c:\\IS Transfer\\Source\\React\\react\\package.json",
        "parent_id": null,
        "fsPath": "c:\\IS Transfer\\Source\\React\\react\\package.json",
        "workspaceRoot": null,
        "workspacePath": null,
        "id": "LA5hepTq19MmnEFv"
    },
    {
        "type": "File",
        "name": "c:\\Windows\\System32\\drivers\\etc\\hosts",
        "parent_id": null,
        "fsPath": "c:\\Windows\\System32\\drivers\\etc\\hosts",
        "workspaceRoot": null,
        "workspacePath": null,
        "id": "ITXtNfRK8hCOeqP6"
    }
]
jeromeboivin commented 4 years ago

I have the same issue since VSCode upgraded to version 1.47.0

jeromeboivin commented 4 years ago

You must have this line in the package.json file of your extension: "enableProposedApi": true. https://code.visualstudio.com/updates/v1_27#_proposed-extension-apis

csicky commented 4 years ago

Came here to report this.

shiraze commented 4 years ago

You must have this line in the package.json file of your extension: "enableProposedApi": true. https://code.visualstudio.com/updates/v1_27#_proposed-extension-apis

I think that setting is only needed if the extension is using proposed api functions. I don't think this extension has changed in a long time, so I think VSCode is probably to blame.

shiraze commented 4 years ago

https://github.com/microsoft/vscode/issues/102530

shiraze commented 4 years ago

This is supposed to be fixed in VS Code 1.47.2

shiraze commented 4 years ago

I can confirm that VS Code 1.47.2 has fixed the issue. I now see Favorites and no warning: image