search

kdcro101 / vscode-favorites

Add files and directories to workspace favorites. You can create groups (and subgroups) of favorite items with files and folders. Time saver for complex projects.
MIT License
49 stars 13 forks source link

Additional contexts for which the "Add to Favorites *" context menus #67

Closed CommanderPho closed 1 year ago

CommanderPho commented 2 years ago

Additional contexts for which the "Add to Favorites" and "Add to Favorites Group" context menu items appear

enabled the "Add to Favorites" and "Add to Favorites Group" context menu items in additional context menus such as when right clicking an open file tab, or in the text of an open editor.

VGvPoz4zWz VGvPoz4zWz 6BgPimnd7Q

45

GitMensch commented 2 years ago

Thanks for the addition to the file tab; I agree that adding to open editors would be useful, you may want to check / ask at stackoverflow for the necessary API config (package.json) or API calls (would be triggered by extension activation).

For the context menu in the editor: I understand that some people want everything there, but at least for me this list should be very consise; can you please split this PR to have this part separate; and maybe add a configuration there?

CommanderPho commented 2 years ago

For the context menu in the editor: I understand that some people want everything there, but at least for me this list should be very consise; can you please split this PR to have this part separate; and maybe add a configuration there?

Sure, I think you're right that adding a configuration setting to determine whether it appears in the editor menu is the way to go. I'll implement this when I get a chance. I'm new to VSCode extension programming and Typescript in general, so I'm still learning.

CommanderPho commented 2 years ago

I added the suggestions proposed by @GitMensch regarding configuration options that control which context menus the "Add to * favorites" items appear in. The settings are depicted below: UtVVzeOKSV

Let me know if there are any other changes to be made, otherwise I'd declare that this feature is mostly complete.

GitMensch commented 1 year ago

Coming back because of https://github.com/open-vsx/publish-extensions/pull/576 - maybe it is time to recognize that @kdcro101 does not have any real activity on GithHub since quite a while... @CommanderPho What do you think of "permanently fork" and create an official new version which could then also be published to open-vsx?

CommanderPho commented 1 year ago

If @kdcro101 is completely inactive I'm willing to create a permanent fork to continue development, but I'm not sure what I would need to do regarding the version published on the VSCode Marketplace (and thus findable via the built-in search): https://marketplace.visualstudio.com/items?itemName=kdcro101.favorites

I suppose if I were to take over the role of lead maintainer, it might be easiest in terms of discovery to name it 'Favorites V2' or something similar? I'll look into in the upcoming week and give @kdcro101 a bit more time to respond before we make any decisions, as after-all it's his idea.

kdcro101 commented 1 year ago

@CommanderPho thank you so much for the contribution. I'll publish the extension in following days. Sorry for the late response.

GitMensch commented 1 year ago

Yay!!!

GitMensch commented 1 year ago

I'll publish the extension in following days.

Hm, rechecking shows that the last released version is still 2.4.5 from 2018. @kdcro101 Do you plan to publish the new version (2.4.6) and create a tag for it (last tag was 2.3.0)?