search

kdcro101 / vscode-favorites

Add files and directories to workspace favorites. You can create groups (and subgroups) of favorite items with files and folders. Time saver for complex projects.
MIT License
49 stars 13 forks source link

Cannot add files from explorer with custom titleBarStyle #7

Closed tuur29 closed 6 years ago

tuur29 commented 6 years ago

The setting "window.titleBarStyle": "custom" was introduced in the May 2018 update. When this setting is set to custom nothing happens when I click "Add to Favourites". It does show the correct popup when adding to groups. but again, nothing happens when I press enter.

I know it's only a preview not, but i wanted to give you a heads up so it can get fixed once it's out of beta.

kdcro101 commented 6 years ago

@tuur29 ,

Thank you for your feedback.

I guess it's a bug on in Vscode https://github.com/Microsoft/vscode/issues/53665. I can see they added it to July 2018 milestone.

Let's be patient, and see what will happen on next release. Problem is, when command is executed from explorer it should send two parameters: currently clicked file selected and list of selected files.
At moment list of selected files is empty (bug) which is used for lately added functionalitiy to allow multiple selected files to be added to favorites/group.

I will try to make a fix so at least you can add currently selected file/directory in "window.titleBarStyle": "custom" mode, until VSCode team fixes this.

kdcro101 commented 6 years ago

@tuur29 ,

Please, update to 1.5.2.

Now, when in "window.titleBarStyle": "custom" mode. You can add single file/directory to favorites/group. Multiple selection will not work until they fix bug in vscode.

tuur29 commented 6 years ago

Thanks for looking the issue up and providing a temporary fix!

kdcro101 commented 6 years ago

@tuur29 ,

No problem! Thank you for notifiying me!

kdcro101 commented 6 years ago

@tuur29 ,

Still a problem with 1.26.0. I can see they transfered issue to August 2018 milestone

kdcro101 commented 6 years ago

@tuur29 ,

Problem is fixed with latest version (1.27.0) (tested on linux). Closing this issue.. If you have any problems, open issue.

Happy coding