search

kdebisschop / rundeck-rancher-node-plugin

Manage Rancher-controlled Docker containers in Rundeck
Apache License 2.0
5 stars 0 forks source link

timeout settings #28

Open mashwino opened 4 years ago

mashwino commented 4 years ago

Hi, I read that timeout for job execution could be set, but I did'nt find how. Is this features available as a job "option" or as a config option ? Thank you. Regards

kdebisschop commented 4 years ago

It is a configuration in the "Default Node Executor" tab when you "Edit Configuration..." under "Project Settings"

kdebisschop commented 4 years ago

Also accessible in the text config as

project.rancher-node-executor-timeout=36000

mashwino commented 4 years ago

Thank you to save my time :-). Could be a good thing to have it available as a job option ?

kdebisschop commented 4 years ago

Since it closes automatically as soon as the remote job is done, the timeout is really just a safety against DOSing ourselves. You really could make it large and not worry. I don't really think it's worth the extra code or extra settings you're need to think about on every job creation.

It would be a low priority in any case.

mashwino commented 4 years ago

Hi, the timeout could be a clue as well for a job to know if every thing went "normaly" and when you have jobs that last few minutes for certains and few hours for the others on a same project, it's not easy to set an appropriate timeout :-/ thank you for your time, hope this feature can be include in next releases. Regards,

kdebisschop commented 4 years ago

I see your point about using duration to determine if a job is healthy -- but in most cases if I time it out, I risk leaving something broken. I think you would be much better off using a configuring a notification when average duration is exceeded. And since there is a purpose built tool for this in RunDeck notifications, I think that is a better choice.

When some jobs take seconds and others take hours, it is fine to take the longer time -- I have a project where the timeout is 10 hours.

I will keep this as a possible feature request, but it still seems like a very low priority.