kdecker-berkeley / discoveryengine

https://cwolfsonseeley.github.io/discodocs/
Other
1 stars 1 forks source link

has_interest_comment #42

Closed tarakc02 closed 7 years ago

tarakc02 commented 7 years ago

from ML: would be useful to be able to search comments of interest codes when doing prospecting for stuff that is more specific than interest code. this was in response to the following actual request that came in: "pull a list of prospects for cancer, pediatrics, pediatric oncology (as separate from cancer and pediatrics), and immunotherapy." Here is one suggested part of that constituency:

has_interest (HEA) %and% has_interest_comment ("cancer")

tarakc02 commented 7 years ago

An alternative is to incorporate comment search directly into the widgets where it would make sense, ie:

has_interest(HEA, comment_text = "cancer")

The advantage is that this mirrors what a user most likely is expecting in this kind of search (the first example would include entities who have multiple interest codes where one of them is "HEA" but doesn't have "cancer" in the comment, and and another one is some other interest code that does have "cancer" in the comment, which seems to break with user expectations. The downside is that this would upset the standard interface for regex-based widgets:

# the current standard
has_interest_comment("cancer", "oncolog*")

# but:
has_interest(HEA, comment_text = c("cancer", "oncolog*"))

Perhaps that's ok?