kdidenko / tabsaver

TabSaver is a Google Chrome extension for selectively `Saving` opened browser `Tabs` list for later.
https://tabsaver.github.io/
GNU Lesser General Public License v3.0
2 stars 0 forks source link

Fix all warning reported by JShint files linting #13

Open kdidenko opened 6 years ago

kdidenko commented 6 years ago

There are no errors but project have around 18 warnings, they all must be fixed:

ws1@kdidenko ~/projects/TabSaver/src/tabsaver
$ grunt --force jshint
Running "jshint:build" (jshint) task

src/scripts/dialog.js
  line 94   col 39  Missing semicolon.
  line 31   col 15  Weird construction. Is 'new' necessary?
  line 134  col 1   Missing '()' invoking a constructor.
  line 134  col 2   Missing semicolon.
  line 214  col 13  Unnecessary semicolon.
  line 258  col 49  Functions declared within loops referencing an outer scoped variable may lead to confusing semantics.
  line 339  col 20  Functions declared within loops referencing an outer scoped variable may lead to confusing semantics.
  line 142  col 16  Weird construction. Is 'new' necessary?
  line 374  col 1   Missing '()' invoking a constructor.
  line 430  col 2   Unnecessary semicolon.
  line 440  col 2   Unnecessary semicolon.

src/scripts/identity.js
  line 81   col 47  Missing semicolon.
  line 146  col 37  Misleading line break before '+'; readers may interpret this as an expression boundary.
  line 152  col 29  Misleading line break before '+'; readers may interpret this as an expression boundary.
  line 168  col 6   Missing semicolon.

src/scripts/popup.js
  line 37   col 43  Functions declared within loops referencing an outer scoped variable may lead to confusing semantics.
  line 42   col 2   Unnecessary semicolon.
  line 80   col 33  Confusing use of '!'.

  ‼  18 warnings

Warning: Task "jshint:build" failed. Used --force, continuing.

Done, but with warnings.
kdidenko commented 6 years ago

Files having warnings: