Closed ttriche closed 6 years ago
Hi @ttriche,
Thanks for the bug report. I think it is related to these recent issues in bsseq
: hansenlab/bsseq#65 and DelayedArray
: Bioconductor/DelayedArray#16
I'll follow up with the bsseq
/DelayedArray
authors about a fix.
Best, Keegan
Hi @ttriche,
The issue has been fixed by the bsseq
authors by swapping dependency on MatrixStats
for DelayedMatrixStats
. I can make this change for dmrseq
if you are still getting the error after installing the newest version of bsseq
from hansenlab/bsseq
. Let me know; I have been unable to reproduce the error on my machines.
Best, Keegan
Hi @ttriche,
I have updated the package to use the rowSums2
, rowMeans2
, colSums2
and colMeans2
functions from DelayedMatrixStats
. I hope this resolves the issues you've been experiencing. These changes should propagate to the release version of Bioc 3.7 on May 1; in the meantime it's safer to install from Github during the transition.
Best, Keegan
Right on -- will do. Thanks for the fixes -- still playing with the various options for dmrseq to tune it for [e]RRBS and mid-coverage WGBS -- but it's a great framework. My undergraduate intern who's planning to work on N-of-1 permutations starts on May 14th, so it's great to resolve this now rather than then :-)
Much obliged.
--t
On Sun, Apr 29, 2018 at 5:13 PM, Keegan Korthauer notifications@github.com wrote:
Hi @ttriche https://github.com/ttriche,
I have updated the package to use the rowSums2, rowMeans2, colSums2 and colMeans2 functions from DelayedMatrixStats. I hope this resolves the issues you've been experiencing. These changes should propagate to the release version of Bioc 3.7 on May 1; in the meantime it's safer to install from Github during the transition.
Best, Keegan
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kdkorthauer/dmrseq/issues/10#issuecomment-385282209, or mute the thread https://github.com/notifications/unsubscribe-auth/AAARIkC6pxp3WI-MjcphLEf2zfy0yrZRks5ttizfgaJpZM4Thmrb .
this is fixed by the rowMeans2/rowSums2 updates. Thanks Keegan!
This is a new development; I'm not sure what's behind it. But it's killing every dmrseq run now...
Running the -3.4 branch from github as of 4/23/2018: