kdl-org / kdl

the kdl document language specifications
https://kdl.dev
Other
1.1k stars 61 forks source link

fix: unescaped / in quoted type tests #194

Closed danini-the-panini closed 2 years ago

danini-the-panini commented 2 years ago

There seem to be a few test cases that have a / in a quoted string used in a type annotation, which I believe is meant to be escaped. This differes from the all_escapes test case, which does escape the /.

zkat commented 2 years ago

Interesting. You shouldn't have to escape / in regular strings?

hkolbeck commented 2 years ago

I think / is weird in that it can be escaped, but doesn't have to be in other places as well. I think it's fine unescaped here.

danini-the-panini commented 2 years ago

I've proposed an alternate solution here: #197

danini-the-panini commented 2 years ago

Alternatively, #198