kdl-org / kdl

the kdl document language specifications
https://kdl.dev
Other
1.09k stars 61 forks source link

Test files include tests that disagree with spec #266

Closed pingiun closed 2 years ago

pingiun commented 2 years ago

I'm not 100% sure how the test cases are expected to work, because some input tests don't have a corresponding file in expected_kdl. I was running my parser against all the files in the input directory and found the underscore_at_start_of_hex.kdl file. According to the grammar in the spec, underscores at the start of numbers should not be allowed

zkat commented 2 years ago

https://github.com/kdl-org/kdl/blob/main/tests/README.md#full-document-test-cases

input files with no corresponding file inexpected_kdl are supposed to be parser errors :)

pingiun commented 2 years ago

Thanks, I must've missed that sentence