search

kdlucas / byte-unixbench

Automatically exported from code.google.com/p/byte-unixbench
GNU General Public License v2.0
1.27k stars 323 forks source link

Handle POWER architecture for unsupported option #55

Closed harish-24 closed 6 years ago

harish-24 commented 6 years ago

-march=native is not supported on power architectures. Handled it in this patch as to skip on POWER

Signed-off-by: Harish harish@linux.vnet.ibm.com

ThinkOpenly commented 6 years ago

Why do you think "-mcpu=native" is not supported on POWER?

ThinkOpenly commented 6 years ago

Actually, I misread the patch. You are removing "-march=native", which is not supported on POWER. However, "-mcpu=native" is supported. Perhaps the removal should instead be a change to "-mcpu=native" ?

harish-24 commented 6 years ago

@ThinkOpenly You are right. It should change to -mcpu=native. Should I force push here?

kdlucas commented 6 years ago

Just send a pull request and I'll push it.

Kelly kdLucas

On Sun, Jan 28, 2018 at 9:24 PM, Harish notifications@github.com wrote:

@ThinkOpenly https://github.com/thinkopenly You are right. It should change to -mcpu=native. Should I force push here?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/kdlucas/byte-unixbench/pull/55#issuecomment-361143464, or mute the thread https://github.com/notifications/unsubscribe-auth/ADk_fcSdAWOX8PkHo8-D2EzC6d7RJP7iks5tPVYrgaJpZM4RkLdI .