search

kdn251 / interviews

Everything you need to know to get the job.
https://www.youtube.com/channel/UCKvwPt6BifPP54yzH99ff1g?view_as=subscriber
MIT License
63.61k stars 12.9k forks source link

Heap image is misleading #85

Open SamuelYvon opened 6 years ago

SamuelYvon commented 6 years ago

The heap.png image in the readme (https://raw.githubusercontent.com/kdn251/interviews/master/images/heap.png) shows a tree that does indeed respect the heap order property. The problem is when you mention the time complexities. In order to have O(log(n)) insert / remove time you also need for your heap to be a complete binary tree. The heap in the picture is not a complete binary tree. I think it should at least be mentioned in the description that the property is only valid for such trees, otherwise it is somewhat misleading.

AdityaPai2398 commented 6 years ago

You're right, The tree added doesn't follow the heap properties.

In order for a Binary Tree to be considered a heap, it must meet two criteria. 1) It must have the heap property. 2) it must be a complete tree.

They have added a wrong representation image.