kdomanski / iso9660

A go library for reading and creating ISO9660 images
BSD 2-Clause "Simplified" License
257 stars 43 forks source link

fix: support Windows paths + example to recursively create an ISO image from the given directories #17

Closed aminya closed 2 years ago

aminya commented 2 years ago

Fixes #16

codecov-commenter commented 2 years ago

Codecov Report

Merging #17 (a54cc3f) into master (7e87c84) will decrease coverage by 0.08%. The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   68.24%   68.16%   -0.09%     
==========================================
  Files           4        4              
  Lines         948      955       +7     
==========================================
+ Hits          647      651       +4     
- Misses        212      214       +2     
- Partials       89       90       +1     
Impacted Files Coverage Δ
image_writer.go 73.24% <57.14%> (-0.26%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7e87c84...a54cc3f. Read the comment docs.

kdomanski commented 2 years ago

Thanks @aminya , much appreciated. I'll see if I can also add integration tests for Windows.