search

kdoroszewicz / dni-robocze

Kalkulator ilości dni roboczych pomiędzy 2 datami. Za dni nierobocze przyjmuję święta państwowe, soboty i niedziele.
dni-robocze.leszcz.vercel.app
0 stars 0 forks source link

No work days not working #327

Open stefaner1 opened 1 year ago

stefaner1 commented 1 year ago

Hello,

Firstly, I want to extend my gratitude for your efforts in maintaining this valuable resource; it's been instrumental in my recent projects.

I am reaching out to bring to your attention a potential oversight in the current version of the code. I have noticed that certain public holidays - specifically 1-3 May, 1 and 11 November, and 25-26 December - are not being recognized as non-working days within the system.

Here it also not working: https://dni-robocze-leszcz.vercel.app/ https://kalkulatordniroboczych.pl/

This has resulted in a bit of an issue for my use case, which relies on accurate reflection of national holidays for scheduling purposes.

It would be incredibly helpful if these dates could be incorporated into the list of non-working days within the project's functionality.

stefaner1 commented 1 year ago

Hello @kdoroszewicz ,

I'm following up on my previous message about updating the public holidays in our system. It's a critical update for my project, and I'd really appreciate your help with it.

If you're currently unable to make this change, could you let me know? Also, if you can share what the issue might be, I'm willing to look into it myself. This info would be really helpful for me to find other ways to address it.

Thanks for looking into this, and I'm looking forward to hearing from you.

kdoroszewicz commented 1 year ago

Hi, @stefaner1 sorry for late response but I missed your previous message. I'm basing my calculation on the output of date-holidays library https://github.com/commenthol/date-holidays and currently have no plans to implement custom holidays ranges in addition to what the library returns. Maybe you should file an issue in date-holidays repo ?