search

kdouy / microsoftrbx-cursor-fix

Cursor bug fixes for Microsoft Roblox
52 stars 17 forks source link

Improve the border lock logic #32

Open zzahkaboom24 opened 1 year ago

zzahkaboom24 commented 1 year ago

Closes #31 Closes #27 Solves the issues from the 2 comments from #26 Closes #25

This improves the border lock logic to the point where it feels almost native. I also handpicked the pixels to cover the following scenarios:

Windowed -> Does not go up to the titlebar on Windows 11 Fullscreen -> Does not trigger the titlebar and the taskbar on fullscreen on Windows 11

Windows 10 ~I have not tested yet~ I now actually did test. I (still) feel like I will need to do some changes there due to the (potentially) different sized UI.~, but will test later in a VM.~

Also multimonitor setup I couldnt test yet, so I dont know if it might misbehave or not if someone plays Roblox on his second monitor which is not set up as his primary monitor.

Lastly, disabling option 2 or 3 might make it look like its not disabled (border lock wise), but it is. To make the cursor escape the window again, just press alt + tab once and then its fully disabled.

Video with this PR:

https://github.com/mengdeveloper/microsoftrbx-cursor-fix/assets/42496614/d6024a1c-75ff-4638-930a-a04267c1f5c9

zzahkaboom24 commented 1 year ago

Dont merge yet. I am still discussing with people from the issues while sending them the binary to try it out. Once #31 turns out to be good, I will implement the changes on here as well, and then it can be merged.

zzahkaboom24 commented 1 year ago

I havent received any answer for now, so I think its fine to merge as-is. In case of anyone else having issues, I will try fixing them as usual. Any additional fine-tuning I will either add here before its merged, or in follow up PRs.

keplerHaloxx commented 1 year ago

You should probably just fork and add to this in your own repo. Last time you got a merge I had to personally message the creator to tell them.

kdouy commented 1 year ago

I be checking everyday dude

kdouy commented 1 year ago

I havent received any answer for now, so I think its fine to merge as-is. In case of anyone else having issues, I will try fixing them as usual. Any additional fine-tuning I will either add here before its merged, or in follow up PRs.

Is it fine to merge now?

keplerHaloxx commented 1 year ago

I be checking everyday dude

i never be seeing you ok

zzahkaboom24 commented 1 year ago

You should probably just fork and add to this in your own repo. Last time you got a merge I had to personally message the creator to tell them.

I actually did. But I also wanted to PR at the same time, so I did

zzahkaboom24 commented 11 months ago

I havent received any answer for now, so I think its fine to merge as-is. In case of anyone else having issues, I will try fixing them as usual. Any additional fine-tuning I will either add here before its merged, or in follow up PRs.

Is it fine to merge now?

In case my lack of an answer seemed like a no to you; Yes, it is fine to merge