search

kdrag0n / android12-extensions

Enable and customize hidden features on Android 12.
MIT License
437 stars 35 forks source link

The Circle Icons overlay is in the wrong path #5

Closed TheBeast0403 closed 3 years ago

TheBeast0403 commented 3 years ago

On the Android 12 Beta 4 GSI (Build Number SPB4.210715.014) the icon overlay is meant to be in /system/product/overlay however your magisk module attempts to put it in /system/overlay which does not exist. Manually editing the folders inside the zip according to the folder structure present on my phone has fixed the problem.

Edit: the circle icon theme seems to work in Launchair 11 alpha 6.1, doesn't seem to work in Quickstep or the settings app

kdrag0n commented 3 years ago

Does it show up if you run cmd overlay list? It used to be in /system/product/overlay, but I moved it to /system/overlay in order to fix bootloops on some unofficial semi-GSI ports of the Pixel beta builds.

TheBeast0403 commented 3 years ago

Yeah it shows up as com.android.theme.icon.circle but I'm using the my edited one (i.e. the one with the overlay in /system/product/overlay)

kdrag0n commented 3 years ago

Can you check with the default /system/overlay path? It should work as far as I know, but I don't currently have an AOSP GSI installation to test it.

TheBeast0403 commented 3 years ago

Switched back to your version. The overlay no longer shows when running the command (nor does it show up in its respective place when using a root browser).

TheBeast0403 commented 3 years ago

Just did a fresh install of Android 12 Beta 4 (since the Beta 5 GSI doesn't seem to boot on my phone) and it turns out that Quickstep does in fact have circle icons now (but it only worked after toggling the option twice)

I used the edited module again since the overlay doesn't seem to be working in your version

kdrag0n commented 3 years ago

Fixed in v8.0.0. Thanks for the details!