search

kdrag0n / safetynet-fix

Google SafetyNet attestation workarounds for Magisk
MIT License
6.15k stars 325 forks source link

Magisk Alpha loosing root #144

Open dariusz-goc opened 2 years ago

dariusz-goc commented 2 years ago

Hi,

There's this Magisk mod called Magisk Alpha (https://t.me/magiskalpha) that is based on latest Magisk, but still includes deprecated Magisk Hide mechanism when Zygisk is disabled (for users who rely on Riru modules that do not yet have a Zygisk version).

The downside is it doesn't hide su binary or unlocked bootloader very well, and that's where your module comes useful. It fixes those and all protected apps seem to work.

However Magisk Alpha app only detects Magisk installed after w reboot. If at any point the app is force closed on any subsequent lunch Magisk seems to be hidden from it, it doesn't detect it anymore, and all root apps loose root access as a result. This doesn't happen with your module disabled. It seems it's so good at hiding that it hides Magisk from Magisk app ;)

Could you take a look at it please? Maybe you'll be able to fix it 🤞

George-Seven commented 2 years ago

Same issue here.

dariusz-goc commented 2 years ago

Just a heads-up for you and anyone interested I found that older non-Riru version works fine for now (1.2.0) 👍

MlgmXyysd commented 2 years ago

The problem is not related to this module. You should use the official version of Magisk (even the older version that includes MagiskHide) instead of going to an untrustworthy third-party version.

xAffan commented 2 years ago

I suggest using magisk delta if you want magisk hide. Alpha is closed source.