kdrag0n / safetynet-fix

Google SafetyNet attestation workarounds for Magisk
MIT License
6.18k stars 324 forks source link

2.1.0 Breaks Fingerprint Sensor - OP8T #92

Closed ohioyj closed 3 years ago

ohioyj commented 3 years ago

Installing the latest release of safetynet-fix "breaks" the fingerprint sensor on the OnePlus 8T. After installing the finger print sensor will say hardware unavailable. Removing the module and rebooting will make the sensor function again. At first I thought it was just a coincidence, however I did get confirmation of this behavior on the 8T on the telegram group as well. Please let me know what other information I can supply that maybe helpful, it diagnosing this issue. I'll be happy to help.

osm0sis commented 3 years ago

I already have a fix (#90) submitted since a couple hours after release last night, so hopefully @kdrag0n can review, merge and release v2.1.1 with the fix shortly. 👍

To get v2.1.0 working in the meantime you can follow my instructions here: https://forum.xda-developers.com/t/magisk-module-universal-safetynet-fix-1-1-0.4217823/page-59#post-85631613

ohioyj commented 3 years ago

You already tested this on your 8T, but I can confirm this also works / fixes my 8T as well.

osm0sis commented 3 years ago

You should leave this open so nobody opens a duplicate issue. It'll automatically be closed when my fix is merged. 👌

Killer-931 commented 2 years ago

Am getting an issue with my Fingerprint Scanner not working, I'm also on a OnePlus 8T, how do I fix this? Screenshot_2022-05-21-05-15-08-20_785cfb1f0fb0c9a2030c9b38a1c3479a

osm0sis commented 2 years ago

It's fixed in the code here, but it hasn't been released. You can add it manually for now.

Killer-931 commented 2 years ago

https://user-images.githubusercontent.com/42481122/169601751-af4aa53e-7106-438d-9c82-3cadabc75a85.mp4

What do and Please show, don't tell, I am extremely dumb.

Edit: Audio is YT in background, woops.

osm0sis commented 2 years ago

Nope, I already have, read back to my last reply.

Killer-931 commented 2 years ago

It's fixed in the code here, but it hasn't been released. You can add it manually for now.

Explains everything I need to know.

https://user-images.githubusercontent.com/42481122/169606632-64544f89-4d12-4cb4-86c2-675dcd919b6d.mp4

osm0sis commented 2 years ago

🙄

No, read. My last reply: https://github.com/kdrag0n/safetynet-fix/issues/92#issuecomment-919494445

Killer-931 commented 2 years ago

🙄

No, read. My last reply: #92 (comment)

And read Mine. Please Show don't Tell.

You have screen recorder on your OnePlus too. If that's too much to ask, I'll go without or try and figure it out.

Visual aid would be epic.

Killer-931 commented 2 years ago

Doesn't work anyway. Am not using Riru. Screenshot_2022-05-21-07-08-03-38_785cfb1f0fb0c9a2030c9b38a1c3479a

Killer-931 commented 2 years ago

And and putting these two files into the non Riru version, 2.2.1 doesn't fix the issue. Screenshot_2022-05-21-07-22-10-11_2602b93dc3ef59eeb51bac049073361e

Vladi69 commented 2 years ago

I already have a fix (#90) submitted since a couple hours after release last night, so hopefully @kdrag0n can review, merge and release v2.1.1 with the fix shortly. 👍

To get v2.1.0 working in the meantime you can follow my instructions here: https://forum.xda-developers.com/t/magisk-module-universal-safetynet-fix-1-1-0.4217823/page-59#post-85631613

Dear @osm0sis is it the solution yet? I can not figure it out. Do I need to install riru module?

Thx

osm0sis commented 2 years ago

It's a script file, you just need to make the edit or replace it, as described in the linked post.

Vladi69 commented 2 years ago

Ok, I will do it tonight at home, same replaced files for riru and zygisk will work? Or only riru is working?

Thx for your quick reply!

osm0sis commented 2 years ago

I only use Zygisk, should be the same though

Vladi69 commented 2 years ago

I only use Zygisk, should be the same though

@osm0sis I am sorry, but I am not able to solve this issue. What I did is to overwrite service.sh and system.prop in the following modules:

None of them worked for me. As I also have an OP8T, can you please share your modded module working with Zygisk, please? You also helped me a lot in the AAwireless implementation, I am in that group, my respect to you.

Thank you!

osm0sis commented 2 years ago

It worked for @ohioyj, who created this issue, so I'm not sure what to tell you. Personally I'm not updating to OOS12 at all... At least not until they get their shit together and release usable kernel source.

osm0sis commented 2 years ago

Oh wait, duh, you guys, this is the old issue from way back for originally adding OOS support.. The later fix for OOS12 is here: https://github.com/kdrag0n/safetynet-fix/pull/164

Vladi69 commented 2 years ago

Oh wait, duh, you guys, this is the old issue from way back for originally adding OOS support.. The later fix for OOS12 is here: #164

@osm0sis great, it did the job, sorry I didn't see the correct issue! Later I will share the modded module, if I can, in #164