kdrag0n / safetynet-fix

Google SafetyNet attestation workarounds for Magisk
MIT License
6.16k stars 325 forks source link

SafetyNet-Fix 2.1 (probably also 2.1.1) breaks NGA #93

Closed SirBughunter closed 2 years ago

SirBughunter commented 2 years ago

Edit: Continued Conversation is also broken by the module.

On Android 12 (probably also other Android versions & or devices) flashing the SafetyNet-Fix v2.1 breaks the New Google Assistant on the Pixel 4. It doesn't show the "Your assistant needs additional downloads." which is necessary for the New Google Assistant to operate.

It also switched the design of my phone from a seemingly outdated one to a very modern one that seems more Material You like. I don't mind that at all^^

[It might also have broken Continued Conversation from the New Google Assistant. But that could also just be the Google App beta build I'm currently using.]

AzizKamboh commented 2 years ago

Google assistant broken on Android 11 too

Nicolas22320 commented 2 years ago

I'm in pixel 5 last update with last safety net fix and no issue with my assistant. Fully work

vaugerbird commented 2 years ago

I'm on Pixel 4a with Android 12 B5, and my assistant has reverted to the original card style from the transparent Pixel exclusive style. Otherwise, I see no problems.

creeve4 commented 2 years ago

I found an unintended side affect of the new bypass methods introduced in 2.1.0: my Pixel 4a running Android 11 is no longer recognized as a Pixel by Google Assistant and thus "Hey Google" is no longer available when the screen is off:

UNSF

Photopuppet commented 2 years ago

Same issue with MIUI 12.5 with 2.1.1, Google Assistant no longer working when screen off. Would be great if this could be fixed. :)

DavidBerdik commented 2 years ago

I found an unintended side affect of the new bypass methods introduced in 2.1.0: my Pixel 4a running Android 11 is no longer recognized as a Pixel by Google Assistant and thus "Hey Google" is no longer available when the screen is off:

I can confirm that I am also seeing the same behavior with v2.1.0 of this module. I am not sure if it happened with the v1 release series.

cmstew commented 2 years ago

I did a little trial and error and found that all the updates 1.2 and newer cause this problem for me (Pixel 3a, Android 11).

It's a pretty minor inconvenience however since Google responded to me in the middle of unrelated conversations half the time. Lol

fishnux commented 2 years ago

I did a little trial and error and found that all the updates 1.2 and newer cause this problem for me (Pixel 3a, Android 11).

It's a pretty minor inconvenience however since Google responded to me in the middle of unrelated conversations half the time. Lol

Pixel 5 here (Android 11). First time installed v2.1.1, noticed NGA broken (screenshot: https://github.com/kdrag0n/safetynet-fix/issues/93#issuecomment-923200701). Downgraded to v1.1.1, NGA functionality restored, then updated one by one till 2.1.1, and NGA keeps working. What kind of magic is this?

So yeah, install SafetyNet Fix v1.1.1 and then update to the latest SafetyNet Fix.

False alarm, refer to next comment of mine

DavidBerdik commented 2 years ago

That doesn't make sense to me. I have used v1.1.1 through the latest version on my phone and I still have this issue on my Pixel 3 XL.

fishnux commented 2 years ago

That doesn't make sense to me. I have used v1.1.1 through the latest version on my phone and I still have this issue on my Pixel 3 XL.

Ok, false alarm. It did work for a brief time, looks like NGA has some sort of cache, so it worked the first couple of times (including after a reboot).

I'm downgrading to v1.2.0 to confirm if this version is responsible for breaking the NGA. Assuming yes, these were the changes between v1.1.1 and v1.2.0: https://github.com/kdrag0n/safetynet-fix/compare/v1.1.1...v1.2.0

Edit after 5 minutes: So far NGA is working with v1.2.0 (downgraded from v2.1.1), will update after 30 minutes Edit after 30 minutes: NGA is still working with v1.2.0 - I would guess v2.0.0 breaks NGA as it was a significant rewrite of the module

DavidBerdik commented 2 years ago

I would guess v2.0.0 breaks NGA as it was a significant rewrite of the module

I'm guessing that @kdrag0n won't bother to fix it then, as I believe he's planning to do yet another major rewrite once Zygisk goes stable.

kdrag0n commented 2 years ago

Fixed in v2.1.2 (for Riru) and v2.2.0 (for Zygisk).