kdschlosser / samsungctl

Remote control Samsung televisions via a TCP/IP connection
MIT License
154 stars 33 forks source link

3 new branches #9

Closed kdschlosser closed 5 years ago

kdschlosser commented 5 years ago

I created 3 new branches

please read the instruction for each branch, I have updated the instructions on use of each of those items as well as code examples.

for controlling applications https://github.com/kdschlosser/samsungctl/tree/add_application

mouse movements https://github.com/kdschlosser/samsungctl/tree/adds_mouse_movements

voice recognition https://github.com/kdschlosser/samsungctl/tree/adds_voice_buttons

kdschlosser commented 5 years ago

I have been informed there may be yet another type of websocket for the TV's this could be why the newest TV's are not able to connect properly.

I do not own one of these TV's so it makes it extremely hard to program for. if you run samsungctl from a command line with -vvvv as a command line parameter it will spit out more information I need ALL of the information and also ALL of any errors that occur. you can copy and paste ot pipe the output to a file.

I cannot get this library right if I am not provided all of the information to do so.

This library does not report the power state of the TV so I am not sure what you mean by state reporting.

No one has provided me with any kind of example code they have used to test with. I do not want to hear anything about the library not working with Home Assistant. I do not really care about Home Assistant. I need to get the library working first. I have people telling me that everything works fine. It seems to be the whoever is using Home Assistant are the people that are having problems.

So my suggestion is if you are having problems when using Home Assistant. that you ask the people at Home Assistant for help. I am not familiar enough with it. I should also not have to supply support for software that uses this library. that is their responsibility.

If one of the people that work on Home Assistant want to ask some questions here and we can get it all hashed out that would be a lot easier to do then having a bunch of people hammering me with non descriptive problems and no logs or errors.

also. people make new issues. if you have a problem make an issue report for it. This is not a blog. each persons problem should have it's own new issue.

I am closing this issue and not going to respond to anything in it anymore.

If you have the same problem as someone else and there is already an issue reported (same problem = exact same error) then simply state I am also having the problem, In the issue that has already been made

I cannot keep track of what problem is what when everything is all jumbled up into a single problem report.

arsaboo commented 5 years ago

Apologies for bringing HA into the mix. I have opened a new clean thread with the relevant logs that does not use Home Assistant.

kdschlosser commented 5 years ago

it is just over complicating things and making it difficult to isolate if the problem is caused by samsungctl or if the problem is with Home Assistant. or maybe something i boogered up in the API

I personally thing it has to do with the websocket-client library. I think th WebSocketApp portion of it has a bunch of issues with it. I rmoveed using the WeebSocketApp portion of the websocket-client library. this is the test branch

https://github.com/kdschlosser/samsungctl/tree/new_websocket_client

so if anyone wants to have a go at it that is the one to try. the only thing i want to have is what gets printed to the screen

iAbadia commented 5 years ago

it is just over complicating things and making it difficult to isolate if the problem is caused by samsungctl or if the problem is with Home Assistant. or maybe something i boogered up in the API

I personally thing it has to do with the websocket-client library. I think th WebSocketApp portion of it has a bunch of issues with it. I rmoveed using the WeebSocketApp portion of the websocket-client library. this is the test branch

https://github.com/kdschlosser/samsungctl/tree/new_websocket_client

so if anyone wants to have a go at it that is the one to try. the only thing i want to have is what gets printed to the screen

Where is this information about a new port coming from? May an nmap run help as well? I'll report as soon as I get home.

kdschlosser commented 5 years ago

actually when i stopped using the WebSocketApp. it corrected what I thought was possibly another variant of the wbsockets. not on a new port. All of the issues stemmed from WebSocketApp. it has a whole slew of problems. I am thinking I now have the connection issues solved. there is no need to worry about what version of websocket client is being used anymore.

I am getting tired of fixing my typos. they really are not typos. it's the E key on my keyboard not working properly. a 4 hour trek for me to get a new keyboard so it is going to wait, I may order one online. I managed to get six months out of this one before it crapped out.

iAbadia commented 5 years ago

Oh man It does work!! Thank you so much ❤

PS: Get a logitech, 25 quid and never had an issue

kdschlosser commented 5 years ago

Trust you me.. I burn through keyboards. 6 - 8 months is the lifetime of keyboards for me. I spent 100.00+ USD (which I believe is 78 quid) on a mechanical key keyboard, so they say these are supposed to last longer.. NOPE. lasts about the same. so don't waste your money buying one that has mechanical keys expecting it to last longer.

I finally managed to find / modify a mouse that I have had for 2 years now, I was going through them at about 1 a year. the left click button would wear out and I would have to really press down on it for it to work. The mouse I have now did the same thing, however I spent a lot on this mouse 120.00 USD hoping the same thing that it would last longer. and it didn't.. but what it did do was last longer then 8 hours without needing to be recharged. I can go almost a week between charges. so I felt this was worth some investigating to see if I could locate new micro switches ones of better build quality. I replaced them with better ones and haven't had an issue with it since. except for having to take the thing apart to clean the mouse wheel so it would move easier. I have dog and cat and it gets all kinds of fur and hair and crap from me into the wheel mechanism which gradually makes it difficult to roll. I like this mouse also because it uses a USB C for charging. and it can be changed and used at the same time using the power from the USB port on the PC. so no additional power adapters.

AdamCavaliere commented 5 years ago

Just to comment here - I finally found at the bottom here the reference to the new_websocket_client branch. Everything finally started working!

kdschlosser commented 5 years ago

@AdamCavaliere

the develop branch is going to have the most recent code changes. At the moment I do not believe it is functioning properly. I am going to push some more code changes to it in a few minutes that should get it working again.