search

kdudka / rrv

Radiosity Renderer and Visualizer
GNU General Public License v3.0
13 stars 1 forks source link

accuracy of form factors #4

Closed claudeha closed 8 years ago

claudeha commented 9 years ago

The current FormFactorEngine calculation of hemicube pixel form factors seems suspect to me after reading this (see pages 5 and 6): http://artis.imag.fr/Members/Cyril.Soler/DEA/IlluminationGlobale/Papers/p31-cohen.pdf

kdudka commented 9 years ago

Thank you for opening the issue! Is this going to be fixed by your patchset at https://github.com/kdudka/rrv/commits/claude ?

claudeha commented 8 years ago

yes - commit https://github.com/kdudka/rrv/commit/d9b85ef8e0f8ef05133a80c74f4f245b4920f098 adds the calculations and commit https://github.com/kdudka/rrv/commit/b7d2a4474431bfdbc99943931519c14b0271f844 makes it the default, both are in your patchset

(apologies for delay, life got in the way)

kdudka commented 8 years ago

Thank you for fixing it! Closing as resolved...