search

kdv24 / Jr-Developer-Site

Website for the Portland Junior Developer meetup
MIT License
3 stars 5 forks source link

:wrench: builds basic Resources component w CSS grid, inline styling #11

Closed alexanderjacks closed 5 years ago

alexanderjacks commented 5 years ago

Initial version of component w/ inline styling-- can adapt to css-modules or similar

kdv24 commented 5 years ago

Great start with CSS grid, @alexanderjacks!

🚧 :art: If you want to play with getting it to be responsive and go to one column as the page shrinks, take a look at this article on how to use CSS grid to make it automatically happen: https://andy-bell.design/wrote/create-a-responsive-grid-layout-with-no-media-queries-using-css-grid/

kdv24 commented 5 years ago

Hey @alexanderjacks sorry I missed seeing you'd made these changes! If something like this ever sits for a long time without a response from me, definitely feel free to ping me on slack and ask about it... chances are I missed it totally or it moved far enough down my list I forgot. 🤦‍♀

Nice work making it responsive! I think we probably will still want to do a bit more to it once we have our designs from Keith. My expectation is we will want the columns to transition straight from 3 to 1 instead of having a midpoint where it does this...

Screen Shot 2019-08-07 at 1 46 54 PM

It looks great on mobile and on full desktop; there's just a range where it looks like that ^ on desktop if you're a certain amount narrower than full screen. You can mess with changing that now, or we can merge it in and update it once we know for sure what our design will be. If you do decide to merge it without changes, can you create a new issue for it so we don't forget? Let me know if you need help knowing how to do that.

Also, there are a couple of conflicts listed. I think both of them will be taken care of if you pull down the latest version of master. I added the package-lock.json to our gitignore file (it gets rebuilt by every time). You can just delete that file locally (make sure it's the lock file though). The other conflict is the index. Again, let me know if you have any questions.

Thanks for your work!