kdzwinel / CSS-Diff

Chrome extension that allows to easily compare CSS of two HTML elements.
GNU General Public License v3.0
200 stars 20 forks source link

Option to change colors for the dark themed devtools #17

Closed modulexcite closed 5 years ago

modulexcite commented 8 years ago

Thank you for an excellent extension. I've zero dark matrix devtools theme installed and the colors for this extension do not play well with that or vice-versa. It would be nice to have an option to change the color scheme.

kdzwinel commented 7 years ago

Thanks for using CSS-Diff and reporting that! This should be a css-only change. From what I know dark version of devtools adds some top-level class that can be used to influence styles of the extension. Feel free to take a stab on this, I'll be happy to help.

rodfersou commented 7 years ago

Awesome extension!

Also I'm getting some issues with the default dark theme of google chrome. Could you please take a look?

UwUnyaa commented 5 years ago

I can confirm that this extension is borderline unreadable with the default dark theme.

kdzwinel commented 5 years ago

Again, please feel free to take a stab at this, it's a "help wanted" task. I'll be happy to review and deploy it.

rodfersou commented 5 years ago

@kdzwinel unfortunately I don't have experience developing extensions, can you please add the basic steps on the readme of the package describing how to do it?

rodfersou commented 5 years ago

or maybe point out where I can find this information

UwUnyaa commented 5 years ago

I wrote styles that work properly with the dark theme and made a pr for them: https://github.com/kdzwinel/CSS-Diff/pull/21 It should be pulled after another PR which upgrades dependencies of the build system which was broken.

kdzwinel commented 5 years ago

Thanks a ton @DoMiNeLa10 ! I'll review, and hopefully merge it, over the weekend.

kdzwinel commented 5 years ago

Thanks to @DoMiNeLa10 we now have a dark mode!!! I'll publish it today in the web store.

Screen Shot 2019-06-10 at 12 13 06