search

ke4roh / vertx-engine

An execution engine for processing things, based on vertx
Apache License 2.0
1 stars 2 forks source link

Run steps as soon as they can be run #51

Closed ke4roh closed 5 years ago

ke4roh commented 5 years ago

This reworks step execution so that as each step finishes, the other pending steps are tried. It relies on Vert.X to honor its threading policy and keep all the event handling in one thread. (So we can assume that, while we're checking things, states (which are set in the event thread) don't change.)

Achtung! I had to increase the timeout to 1.5 sec on the incomplete pipeline test to get it to complete when I ran it from mvn on the command line on my box. For this circumstance, I don't care how long it takes to resolve, but when it's a search that has executed 5 of its 200 searches, I want to see it right away. I'm not sure at the moment why it would take so long. Further investigation is warranted.

ke4roh commented 5 years ago

The coverage report prompted me to fix a bug it revealed and write some tests. Of course, I'm seeing some odd behavior, so... working on fixing that now.

ke4roh commented 5 years ago

I'm thinking a squash commit is in order for this one.