search

ke4roh / vertx-engine

An execution engine for processing things, based on vertx
Apache License 2.0
1 stars 2 forks source link

One HttpClient #73

Closed ke4roh closed 5 years ago

ke4roh commented 5 years ago

Inner classes with different behavior for different methods can provide a body or not and avoid branching.

LightGuard commented 5 years ago

Going to say no on this one. I don’t think it’sa good idea long term

ke4roh commented 5 years ago

The odd part here is that then the Solr client is split among multiple implementations for indexing and querying different ways.

LightGuard commented 5 years ago

I don’t see that as a problem. Of course there isn’ta reason you can’t do your own subclass that does both.