search

keajs / kea-saga

Saga support for kea
https://kea.js.org/effects/saga
MIT License
7 stars 4 forks source link

Kea saga does not include typegen definitions #37

Closed rschyboll closed 2 years ago

rschyboll commented 2 years ago

Hi, i've been working with your library for quite some time now, love it so far.

In the last week i've wanted to incorporate sagas into my workflow, i did notice though, that kea-saga does not work with kea-typegen. In kea-saga docs, it shows that it is possible to define shared workers for other sagas, but kea-saga does not include those in the type of the logic, so it is not possible to use them with typescript.

I did manage to find a workaround for my use case, but to use the plugin it would be helpful to have it work with kea-typegen.

I did look into it myself, but in the limited time i could not find a way to make it, seems that my knowledge of the ts compiler api is not good enough, at least for now :D

mariusandra commented 2 years ago

Hey, the just released version 3.0.1 has typegen support for workers :). Thanks for reporting!

rschyboll commented 2 years ago

Awesome, just tested it, seems to be working correctly, thanks!