search

kean / Get

Web API client built using async/await
MIT License
943 stars 75 forks source link

added support for empty data response #58

Closed Pomanks closed 2 years ago

Pomanks commented 2 years ago

added OptionalDecoding protocol to support returning nil in case of empty data in response

kean commented 2 years ago

This looks good, @Pomanks. I'm happy that this use case will now be supported without introducing any new public APIs.

I would appreciate if you could add a couple of tests, but that's not strictly required. I can merge it as is and add them later prior to the release.

Pomanks commented 2 years ago

Sure thing! I'd rather make sure the implementation was good to go before adding some. I'll push another commit for the tests.