search

kean / Nuke

Image loading system
https://kean.blog/nuke
MIT License
8.12k stars 528 forks source link

Error -17102 decompressing image -- possibly corrupt #799

Closed prabhuamol closed 2 months ago

prabhuamol commented 2 months ago

See this error in the console sometimes. Is this expected?

Screenshot 2024-07-25 at 12 06 15 PM
Saafo commented 2 months ago

Because of https://github.com/kean/Nuke/commit/6c2542848b178b4bc23f7bd56eae2a708eb15007，

f87a6c3a-50e1-403f-a725-e61f147511ba

Hi @kean I'm just wondering why we revert this check?

Ahh I see: https://github.com/kean/Nuke/issues/788

But I'm still wondering whether this log means anything? Can we use preparingForDisplay to decode image in formats that are not jpg/heif?

kean commented 2 months ago

Can we use preparingForDisplay to decode image in formats that are not jpg/heif?

It won't fail, but it will throw this console warning. It's a pita to use 😞 I'm open to suggestions how to improve it.

prabhuamol commented 2 months ago

788

I see, so its something that apple just throws at us when preparingForDisplay is used on PNGs? I'll close this then if we can safely ignore this error

prabhuamol commented 2 months ago

Looks like similar issue was observed here and radar to Apple was filed https://github.com/SDWebImage/SDWebImage/issues/3365#issuecomment-1186105083