search

kean / Pulse

Network logger for Apple platforms
https://pulselogger.com
MIT License
6.18k stars 294 forks source link

Why not use StaticString for #line #function and #file in LoggerStore.storeMessage? #237

Closed Scvairy closed 1 week ago

Scvairy commented 6 months ago

It is a common thing to use StaticString for known at compile-time strings, it reduces overhead of regular modifiable Strings.

Why is it decided to use String instead of StaticString?

Scvairy commented 6 months ago

I'm not sure if we will gain any benefits in performance, but I suggest to give it a try.