Closed Scvairy closed 4 months ago
Hey, thank you for opening the PR, @Scvairy.
Can you please elaborate a bit more on the advantages of using StaticString
in this case? I wonder if the benefits still hold after conversion back to String
.
I haven't used this type before, but it seems like a good candidate in the case of #file
and #function
. On the other hand, if the users want to override the default values, wouldn't StaticString
be a bit more limiting?
I'm going to close it for now. I'd be happy to merge if the rationale is provided for the change that would justify a breaking change in the public API.
For issue #237