search

kean / Pulse

Network logger for Apple platforms
https://pulselogger.com
MIT License
6.18k stars 294 forks source link

visionOS support #239

Closed maximality closed 4 months ago

maximality commented 6 months ago

The current version of the Pulse library does not support the visionOS target, resulting in Xcode generating an error when attempting to build our project with a Pulse dependency for visionOS.

I've decided to fix it. Tested the demo app – works and looks good!

Simulator Screenshot - Apple Vision Pro - 2024-02-18 at 17 11 43

kean commented 6 months ago

Awesome work, @maximality. You got much further than I did when I tried to get it to work on visionOS.

I think we could get this merged in this state and get more folks to contribute and iterate on it. There are some issues with the way the current components work on visionOS. For example, if definitely needs a wider log list, reworked controls, and an improved response body viewer. Unfortunately, I'm not an expert on the visionOS design, so I don't what the solution will be. Maybe it could take more cues from the tvOS components in Pulse.

What are your plans for this PR in particular and visionOS support in general? Would you like to continue pushing it forward?

Btw, I've been in the museum from your profile photo 👋

maximality commented 6 months ago

Hey, @kean!

What are your plans for this PR in particular and visionOS support in general? Would you like to continue pushing it forward?

Well, for now I just use it as in this PR in my project and it does it's job. But I totally agree that we could do a better UI for visionOS. I will try to find some time to think on how we can improve it (not a visionOS expert, but hopefully on my way to). Open to any suggestions from community.

Btw, I've been in the museum from your profile photo 👋

Haha, awesome, small world!

Mcrich23 commented 5 months ago

I think it looks pretty good! only thing I see can be an issue is the blue text in the top left

kean commented 4 months ago

I reviewed the changes and it seems to be good to merge. Thanks for investing your time in this PR, @maximality. It was quite a lot of work, and I appreciate it. If you'd like to continue working on it, your contributions are welcome, and I'll try to provide fast code reviews.

kean commented 4 months ago

There was a merge conflict, so I created a separate PR with a fix, and it is now merged https://github.com/kean/Pulse/pull/249.

maximality commented 4 months ago

Thanks @kean !

Vaberer commented 2 months ago

Are there plans to merge VisionOS support?