Closed Mcrich23 closed 4 months ago
@kean Thoughts?
Hey, @Mcrich23. It's nice to have these convenience methods, but Pulse is primarily designed to be integrated into the existing navigation controllers, so I'm not sure it's worth extending the public API for something relatively trivial. There is also an existing MainViewController
, which probably doesn't have the best name – it used to be a MainView
counterpart, but it has been removed. It should probably be renamed to ConsoleViewController
.
Ok, that is why both of those controller names exist.
Hey, @Mcrich23. I'm going to close the PR if you don't mind and incorporate the changes you suggested but in a slightly different form in the upcoming versions. Thank you for raising this.
I added 3 functions for UIKit:
UIConsoleViewController
is a function that neatly wrapsConsoleView
into UIKit, and yes thecloseButtonHidden
modifier still works (ie.vc. closeButtonHidden(true)
UIConsoleNavigationViewController
is two different functions that support navigation before ios 16 and ios 16+. It is the same asUIConsoleViewController
, but with a navigation wrapper.