search

kean / Pulse

Network logger for Apple platforms
https://pulselogger.com
MIT License
6.18k stars 294 forks source link

Public accessor to server-related methods #273

Closed AvdLee closed 1 month ago

AvdLee commented 1 month ago

To allow for setting up a server-side communication with the RemoteLogger, I've added public attributes to several methods. These are the bare-minimum to potentially set up a custom server for receiving remote logging messages.

kean commented 1 month ago

/Users/runner/work/Pulse/Pulse/Tests/PulseTests/URLSessionProxyDelegateTests.swift:69

These tests've been flaky for some time. I think it's worth disabling them for now.

kean commented 1 month ago

I've added public attributes to several methods.

I'm merging to unblock you for now, but I'll need to revisit it because releasing a new version. The protocol is no secret, but it's not designed to be public.

AvdLee commented 1 month ago

I'm merging to unblock you for now, but I'll need to revisit it because releasing a new version. The protocol is no secret, but it's not designed to be public.

Let me know if I can help!