search

kean / Pulse

Network logger for Apple platforms
https://pulselogger.com
MIT License
6.37k stars 311 forks source link

Logging system initialized correctly #287

Closed Shivani-Bajaj closed 2 months ago

Shivani-Bajaj commented 2 months ago

There is a warning that appears while running the app stating Logging Error: Failed to initialize logging system. Log messages may be missing.?

So to solve this warning, an environmental variable is added to the current scheme IDEPreferLogStreaming=YES warning fix

kean commented 2 months ago

Hey, thanks for the PR 👋 I wonder what is the root cause of the error. It's not something that I saw before and after a quick search I couldn't find anything conclusive. (ignore the CI errors)

Shivani-Bajaj commented 2 months ago

Hey, thanks for the PR 👋 I wonder what is the root cause of the error. It's not something that I saw before and after a quick search I couldn't find anything conclusive. (ignore the CI errors)

It think it to be a bug in 15.3 and above Xcode versions. IDEPreferLogStreaming controls whether Xcode or the IDE should prefer log streaming over direct file writes. So I think in these xcode versions, this is not set by default.

Also, regarding the CI error, there was a compilation error occurring and I commented out that line to run the code. There was a lot of commented code around that, which I am not sure is referred by someone or is unused as of now. So I can remove it as well, but need to know your opinion on that.

kean commented 2 months ago

I am not sure is referred by someone or is unused as of now

It's work-in-progress code for Pulse 5.0. The latest version of the codebase is in the following PR/branch: https://github.com/kean/Pulse/pull/285.

Shivani-Bajaj commented 2 months ago

I am not sure is referred by someone or is unused as of now

It's work-in-progress code for Pulse 5.0. The latest version of the codebase is in the following PR/branch: #285.

Thanks for clarifying. So I don't need to make any changes around that. Will wait for your approval on PR if things seem fine to you.