search

kean / Pulse

Network logger for Apple platforms
https://pulselogger.com
MIT License
6.32k stars 302 forks source link

fix retain cycle. #98

Closed michaelhenry closed 2 years ago

michaelhenry commented 2 years ago

Captured by Xcode's Debug Memory Graph and it is causing some duplicated logs.

kean commented 2 years ago

Thanks, @michaelhenry . Yeah, it makes sense for these to be captured using weak references.

kean commented 2 years ago

I actually have to roll that back, sorry. It breaks the contract that URLSession delegate is strongly retained by the session.