kean / PulsePro

A macOS app for viewing logs from Pulse
https://pulselogger.com
482 stars 24 forks source link

Mac Catalyst support #3

Closed vox-humana closed 3 years ago

vox-humana commented 3 years ago

A feature request for adding Catalyst support. Currently XCFrameworks in Pulse distribution contain only iOS and simulator frameworks.

It needs an extra build for -destination 'platform=macOS,arch=x86_64,variant=Mac Catalyst' according to this beautiful guide https://pspdfkit.com/blog/2020/supporting-xcframeworks/

kean commented 3 years ago

Got it, thanks for the details. I'll push a version with Catalyst support soon. And the initial macOS version.

kean commented 3 years ago

I'm using swift-create-xcframework to create xcframeworks, apparently there is some issue with catalyst https://github.com/unsignedapps/swift-create-xcframework/issues/27. I don't know yet if it's the issue on my side or in the script. I can build the package for Catalyst from Xcode just fine.

vox-humana commented 3 years ago

Thanks for such an instant reply and for the bug reference 👀

kean commented 3 years ago

0.9.5 shipped without Catalyst. It's getting a bit late, I'll see what I can do some time this week.

In the meantime, Pulse macOS Alpha is out. It's attached to https://github.com/kean/PulseUI/releases/tag/0.9.5.

carltongibson commented 3 years ago

Hi, thanks for the work; really excited to be using it!

Trying to install for a multi-platform SwiftUI project.

Get this on building:

While building for macOS, no library for this platform was found in  
'/Users/carlton/Library/Developer/Xcode/DerivedData/.../SourcePackages/artifacts/Pulse/PulseCore.xcframework'.

While building for macOS, no library for this platform was found in 
'/Users/carlton/Library/Developer/Xcode/DerivedData/.../SourcePackages/artifacts/Pulse/PulseUI.xcframework'.

Can I confirm whether this is expected limitation at this point?

Package version is 0.9.8. (I was going to create a new issue, because not Catalyst, but presumably they're solved together? 🤔)

Thanks!

kean commented 3 years ago

Thank you, and thanks for sponsoring!

Yes, this is an expected limitation. Pulse is currently available in a form of a Swift package for iOS apps and a separate macOS app.

I'll prioritize adding support for other platforms and will try to get a new build ready by the end of the day.

carltongibson commented 3 years ago

Hey @kean.

Thanks for the quick reply, and no stress. 🙂 it would be nice to have the macOS build but whatever time line that comes on is fine. (It's the weekend!)

Thanks. C.

kean commented 3 years ago

The new release with macOS and Mac Catalyst support is up https://github.com/kean/PulseUI/releases/tag/0.9.9. I also opened a fix for swift-create-xcframework.

kean commented 3 years ago

(It's the weekend!)

Right, that's when I work on my personal projects 👀

carltongibson commented 3 years ago

Super. Good work. Thanks for the release @kean 👍