Closed keanuplayz closed 2 years ago
And also, since I ripped the code from CCBot's emote command,
Credit where credit is due. I don't want to repeat the events of Re-Jill.
I would personally prefer to keep the current behavior of -
(adding a space, not removing a space).
This seems counter intuitive to me. Why should emotes be stitched together by default?
I feel it makes less sense for one to type a character in an emote call that is meant to actually remove a character. It feels backwards.
Having spaces be manually specified just makes more sense, in my opinion.
Aren't you already typing a space between emotes in the invocation? Why would you want to specify the space again as another character to actually add it to the output?
I would agree with that only if spaces were significant - i.e. putting 3 spaces between two emotes names would result in the message having 3 spaces between the two emotes, and not just 1 space. Using -
as a space adder, and not remover also allows one to do multiple spaces between emotes much more intuitively if one desired.
I would agree with that only if spaces were significant
My final say on this PR will be that readability is significant enough. Stitched emotes look bad.
I will await the proper review before wasting more words on this.
You see, I was fairly confused with the way
.emote
worked. In my opinion, removing spaces should be completely optional, instead of making no spaces between emotes the default. So, hereby,-
now removes the space between emotes,+
still adds a\n
, and_
still adds a\u200b
. No other changes were made. And also, since I ripped the code from CCBot's emote command, the extensibility of the formatting function is now, in my opinion, much easier.