search

keatontaylor / alexa-actions

A README and associated code to get actionable notifications setup for Alexa devices.
GNU General Public License v3.0
399 stars 187 forks source link

Migrate language manifests to make them importable #137

Closed elmar-hinz closed 1 year ago

elmar-hinz commented 1 year ago

The language manifests are migrated into a different location, such that they will be imported automatically. The json content has been regenerated by use of the developer console, which is introducing a version number.

Minor adjustments have been made to names:

skill.json: "Alexa actionable notifications" invocation names: "actionable notifications"

Both are not used to work with this skill. The skill is triggered from the end of Home Assistant by using the skill id.

"actionable notifications" is set for all languages. This may be translated in future, albeit not really needed, as pointed out just before.

Note 1:

The importer always shows a warning, that the invocation name must not be identical with the skill name. It does occure no matter what combinations of names you give. I tested for a whole hour. It's oviously a bug of the importer.

It always does reset the invocation name to "change me". You actually have to set it to something else again. The TEST simulater in the developer console will not detect the skill, if you call "open change me". Use anything else i.e. 'actionable notifications'.

Note 2:

I noticed that it is not enough to provide a language manifest file. There has to be an entry in skill.json as well. In this case it is possible to directly import this language without having to import en-US first.

Note 3:

Most manifests are not really translated and still hold english expressions. Doing translations is out of the scope of this commit.

elmar-hinz commented 1 year ago

I did set the version in the language files to 1. As they are versioned by GitHub, we basically don't need those version numbers and may remove them at all.

This versions only make sense in the context of the developer console for the user himself, when he wants to change his language files after import.

DEADSEC-SECURITY commented 1 year ago

I'm going to review this later today and merge if everything looks fine :) Thanks for the contribution

DEADSEC-SECURITY commented 1 year ago

Merged to a new branch so I can update all languages and make sure it works 100%

elmar-hinz commented 1 year ago

Does the importer take a branch different from master at all? You may want to use a fork of the repo to test it.

DEADSEC-SECURITY commented 1 year ago

master has the importer stuff. I made a new branch from master called migrating languages.

DEADSEC-SECURITY commented 1 year ago

I'm going to review the languages and merge to master if everything checks out.