search

keatontaylor / alexa-actions

A README and associated code to get actionable notifications setup for Alexa devices.
GNU General Public License v3.0
399 stars 187 forks source link

Change change AMAZON.FOUR_DIGIT_NUMBER to AMAZON.NUMBER in interaction-models for all languages. #189

Closed rwunsch closed 1 year ago

rwunsch commented 1 year ago

The Alexa Service only reacted to FOUR DIGIT NUMBERS for the NumberIntentHelper. It did not recognize any one-digit, two-digit ... or 10 digit number as "NumberIntentHandler. Changing the interaction model made it possible to answer to Alexa requests through this skill with a number like "5" or "25436".

DEADSEC-SECURITY commented 1 year ago

Was this tested? What devices did you test this modification? @rwunsch

rwunsch commented 1 year ago

I tested with ECHO DOT 4th GEN. Give me some time (about 3 weeks) and I can do more testing. I am in the hospital with my son until Monday - and only have access to a 4th-gen Dot. The a week of work, followed by 2 weeks vacation - and then I would be able to test on all devices I have (show8, show5, dot 2nd and 3rd) - and share the results.

I wonder, however, how a AMAZON.FOUR_DIGIT_NUMBER would every provide anything else as result, than a 4-digit number...

DEADSEC-SECURITY commented 1 year ago

Hope you guys get better.

Not sure why the original creator choose that FOUR DIGIT but must've been cuz at the time there wasnt any alternatives I guess. I'm algo going to test on my firetv cube.