keatontaylor / alexa-actions

A README and associated code to get actionable notifications setup for Alexa devices.
GNU General Public License v3.0
391 stars 186 forks source link

Remove duplicate and unnecessary code #201

Closed gosoares closed 11 months ago

gosoares commented 1 year ago

I found some duplicated and unnecessary code, and removed it:

DEADSEC-SECURITY commented 1 year ago

Did you test this?

Removing the Borg function breaks the app last time I checked cuz it's how the program saves the state.

gosoares commented 1 year ago

Yes, it's working perfectly here. Maybe it was used before and not anymore? Because the only state that is being used is the one inside the HomeAssistant object that is recreated in each handler.

DEADSEC-SECURITY commented 1 year ago

Ill do some more testing just to make sure. Its a lot of changes.

DEADSEC-SECURITY commented 11 months ago

This breaks a hole set of features. Closing PR