keatonwilson / paleotidal_app

Shiny app for paleotidal modeling for Exeter + Bangor
1 stars 0 forks source link

Connect rasters #28

Closed jessicaguo closed 1 year ago

jessicaguo commented 1 year ago

This PR does the following:

Could use improvement:

keatonwilson commented 1 year ago

@jessicaguo Check out the commits - I got legends working with proxy. A few necessary steps:

  1. adding the legend to the base map
  2. adding legends to each conditional chunk (I only filled in the one that is built - the rest I'll leave up to you)
  3. adding clearControls functions to the top of the proxy builds - this will wipe out the existing legend before adding. It prevents a bug where if you turned coastline off and on, the ice/land legend would keep duplicating onto the map.

I'm not sure it's actually the nested conditionals that are causing the slow response time - it may be the volume of data that we're starting to process and stack. Sophie mentioned that downsampling might be a reasonable alternative, so we have some options.

My vote is to get through initial buildout of things recognizing that things are getting slow, and then spend some time at the end re-tooling and speeding things up. What do you think?

jessicaguo commented 1 year ago

Nicely done! I admit to beating a hasty retreat when I saw the neverending legends.

I agree about the order of operations, just not familiar with the ways to speed things up. But I trust you'll get us there!