search

keattang / poetry-exec-plugin

A plugin for poetry that allows you to execute scripts defined in your pyproject.toml, just like you can in npm or pipenv
https://pypi.org/project/poetry-exec-plugin/
MIT License
58 stars 6 forks source link

Avoid `poetry` calls running `poetry exec` from other commands #9

Closed mondeja closed 11 months ago

mondeja commented 2 years ago

Resolves #7

keattang commented 2 years ago

I'm still not convinced that this is a good idea. If, for example, someone had a plugin that injected environment variables before running commands as described in the poetry docs then this would break that behaviour.

Is there a way to make this opt-in? Perhaps a setting in the pyproject.toml?

mondeja commented 2 years ago

Implemented a tool.poetry-exec-plugin.config configuration object and resolve-poetry-exec option to make this behaviour optional, by default disabled.

Not sure why flake8 is raising the F821 error, I'm not able to reproduce it locally. Could be a cache problem? 🤔

keattang commented 1 year ago

@mondeja if you can merge the latest from the main branch I think that will fix the tests and we can get this merged

mondeja commented 1 year ago

Sorry but I'm not interested in this now because I'm not usinig poetry. Feel free to merge or reopen with the feature by yourself.