search

kebabtent / pogoprotos-php

Compiled PHP protobufs for pokemon go
MIT License
22 stars 8 forks source link

Fix Enums in Repeated fields #11

Closed DrDelay closed 8 years ago

DrDelay commented 8 years ago

Regarding the problem with the PlayerData that I mentioned in #8 .

For now, this requires a fork of mine that fixes the problem. I also opened a PR for the changes here: protobuf-php/protobuf-plugin#3

jaspervdm commented 8 years ago

The author of the PHP protobuf implemented your fix, so we can switch to that one. Also, if you'd like, I sent you an invite to become collaborator on this repo, since you have been working on it as much as I have.

The pokemongodev subreddit also has a discord server where they discuss various issues regarding developing APIs, including attempting to understand Unknown6, which seems to be the cause of breaking all APIs. I requested for them to add a PHP-dev channel as well, which could be useful for our development of the PHP proto classes and eventually a full API. If you are interested, you could join as well.

DrDelay commented 8 years ago

Thank you for the invite!

I changed it to require the version from the official repo again (he already tagged it as (stable) v0.1.2, so I guess ~0.1 is OK.

I'm gonna merge this and #9 , #10 , #12 into the test-protobuf branch, you can merge it to master and tag a release if you feel like everything's good.