kebernet / shortyz

Shortyz Crosswords
GNU General Public License v3.0
106 stars 56 forks source link

Added setting to indicate on the Playboard when 'Show Errors' is enabled. #152

Open runs-with-scissors opened 5 years ago

runs-with-scissors commented 5 years ago

When the "Show Errors Indicator" setting is checked, and "Show Errors" is enabled, the color of each box's borderline is the 'errorColor'

runs-with-scissors commented 5 years ago

Screenshots

screenshot_20190121-013440 screenshot_20190121-013500 screenshot_20190121-013507

gaul commented 5 years ago

I dislike these jarring colors -- could we display a status icon next to the ellipses when the user has a wide screen like a tablet instead?

runs-with-scissors commented 5 years ago

@gaul wrote:

https://github.com/kebernet/shortyz/pull/152#issuecomment-456167429: I dislike these jarring colors -- could we display a status icon next to the ellipses when the user has a wide screen like a tablet instead?

Very good point. I now see how the colors would become distracting/annoying after a while. I think it makes sense to use a status icon for all devices, not just tablets.

Here are a few icons available from the Asset Studio which could work. I think the spellcheck icon would be a good fit for our use case (more optimistic than an error-related icon :wink:)

image

gaul commented 5 years ago

Sounds good for tablets although phones have a limited space for the clue.

runs-with-scissors commented 5 years ago

Instead of adding a status icon, I decided to make it so that the change only applies to the currently selected word and not the whole grid. The red borderline wasn't noticeable enough in day mode, so I changed it to blue and increased its thickness screenshot_20190209-163815-min2 screenshot_20190209-163831-min2