search

keboola / app-orchestrator-trigger

MIT License
0 stars 1 forks source link

Handle user errors #7

Closed ErikZigo closed 5 years ago

ErikZigo commented 5 years ago

Fix: https://github.com/keboola/app-orchestrator-trigger/issues

Handlovani user erroru bylo jen v miste kdy se nacita nazev orchestrace. Presunul jsem to, aby se to handlovalo.

Zafixoval jsem verzi php v docker image, protoze pod php7.3 to hazelo errory.

ErikZigo commented 5 years ago

User error se testoval tady: https://github.com/keboola/app-orchestrator-trigger/blob/61777ccb04125432bba803c7264cae19753ae328/tests/phpunit/FunctionalTest.php#L104

MiroCillik commented 5 years ago

Jo, takze ten test tam uz vlastne je(?)

ErikZigo commented 5 years ago

@MiroCillik jj ten test tam je. Jen jsem ten try/catch presunul o uroven vys.